Skip to content

GitLab

Fix equality comparison for Domains. 

Two different domains can have the same hash.  There's a small chance that two
different strings have the same hash.  This means that, if S1 and S2 are two
such strings; the domains ``[('f', '=', S1)]`` and ``[('f', '=', S2)]`` will
have the same hash, but the two domains are not equal in any possible
interpretation.

We need to find a hash function that ensures that it has the same value for
equal domains, but not base eq on the hash.
4 jobs for eq-domain in 7 minutes and 12 seconds (queued for 3 minutes and 43 seconds)
latest
5947cc94
1 related merge request: !7 Fix equality comparison for Domains.
Status Job ID Name Coverage
  Check
passed #25101
merchise-lint
check code smells

00:00:08

 
  Test
failed #25102
virtualenv xoeuf-tester
run all Odoo 10 tests

00:03:28

failed #25103
virtualenv xoeuf-tester
run all Odoo 11 tests

00:02:51

passed #25104
virtualenv xoeuf-tester
run all Odoo 12 tests

00:03:32

 
Name Stage Failure
failed
run all Odoo 10 tests Test 
2019-03-30 17:14:27,345 3239 ERROR tdb_bbb21f47b odoo.addons.test_unit.tests.test_localtime_as_remotetime: `     test_runner(None, lambda data: test(*arguments, **example_kwargs))
2019-03-30 17:14:27,345 3239 ERROR tdb_bbb21f47b odoo.addons.test_unit.tests.test_localtime_as_remotetime: `   File "/home/gitlab-runner/builds/oJ8qHYrU/0/merchise/xoeuf/xoeuf/tests/test_unit/tests/test_localtime_as_remotetime.py", line 43, in test_local_remote_time
2019-03-30 17:14:27,345 3239 ERROR tdb_bbb21f47b odoo.addons.test_unit.tests.test_localtime_as_remotetime: `     from_tz
2019-03-30 17:14:27,345 3239 ERROR tdb_bbb21f47b odoo.addons.test_unit.tests.test_localtime_as_remotetime: ` AssertionError: datetime.datetime(1946, 1, 1, 0, 0) != datetime.datetime(1946, 1, 1, 1, 0)
2019-03-30 17:14:27,345 3239 ERROR tdb_bbb21f47b odoo.addons.test_unit.tests.test_localtime_as_remotetime: FAILED
2019-03-30 17:14:27,345 3239 ERROR tdb_bbb21f47b odoo.modules.module: Module test_unit: 1 failures, 0 errors
2019-03-30 17:14:43,404 3239 ERROR tdb_bbb21f47b odoo.modules.loading: At least one test failed when loading the modules.
/home/gitlab-runner/.local/bin/runtests-odoo.sh: línea 1: deactivate: No existe el archivo o el directorio
ERROR: Job failed: exit status 1
failed
run all Odoo 11 tests Test 
2019-03-30 17:15:49,749 17030 ERROR tdb_1dc7ae15f odoo.addons.test_unit.tests.test_localtime_as_remotetime: `   File "/home/gitlab-runner/virtualenvs/xoeuf-odoo11/lib/python3.6/site-packages/hypothesis/core.py", line 326, in <lambda>
2019-03-30 17:15:49,749 17030 ERROR tdb_1dc7ae15f odoo.addons.test_unit.tests.test_localtime_as_remotetime: `     test_runner(None, lambda data: test(*arguments, **example_kwargs))
2019-03-30 17:15:49,749 17030 ERROR tdb_1dc7ae15f odoo.addons.test_unit.tests.test_localtime_as_remotetime: `   File "/home/gitlab-runner/builds/8fh82KEs/0/merchise/xoeuf/xoeuf/tests/test_unit/tests/test_localtime_as_remotetime.py", line 43, in test_local_remote_time
2019-03-30 17:15:49,749 17030 ERROR tdb_1dc7ae15f odoo.addons.test_unit.tests.test_localtime_as_remotetime: `     from_tz
2019-03-30 17:15:49,749 17030 ERROR tdb_1dc7ae15f odoo.addons.test_unit.tests.test_localtime_as_remotetime: ` AssertionError: datetime.datetime(1946, 1, 1, 0, 0) != datetime.datetime(1946, 1, 1, 1, 0)
2019-03-30 17:15:49,749 17030 ERROR tdb_1dc7ae15f odoo.addons.test_unit.tests.test_localtime_as_remotetime: FAILED
2019-03-30 17:15:49,749 17030 ERROR tdb_1dc7ae15f odoo.modules.module: Module test_unit: 1 failures, 0 errors
2019-03-30 17:16:13,960 17030 ERROR tdb_1dc7ae15f odoo.modules.loading: At least one test failed when loading the modules.
ERROR: Job failed: exit status 1